Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update de.json #1627

Merged
merged 2 commits into from
Nov 4, 2023
Merged

update de.json #1627

merged 2 commits into from
Nov 4, 2023

Conversation

Staubgeborener
Copy link
Contributor

Update german translation

update german translation
@donavanbecker donavanbecker changed the base branch from latest to beta-4.52.1 November 4, 2023 19:42
@donavanbecker donavanbecker enabled auto-merge (squash) November 4, 2023 19:42
@donavanbecker donavanbecker merged commit 480bdf9 into homebridge:beta-4.52.1 Nov 4, 2023
13 checks passed
@bwp91
Copy link
Contributor

bwp91 commented Nov 4, 2023

@Staubgeborener thanks!

Could you check one more thing for me here:
5e5d2a6

Where I have edited de.json does this make sense:

Vielen Dank für die Installation der {{ targetVersion }} Version von {{ pluginName }}

{{ targetVersion }} can be latest or beta

donavanbecker added a commit that referenced this pull request Nov 4, 2023
## 4.52.1 (2023-11-04)

### Other Changes

- **i18n:** Update de.json ([1627](#1627))

### Bug Fixes

- Fix text in post-plugin-update modal which wasn't showing translated strings properly
- Revert HomeKit code formatting change
@donavanbecker donavanbecker mentioned this pull request Nov 4, 2023
donavanbecker added a commit that referenced this pull request Nov 4, 2023
### Other Changes

- **i18n:** Update de.json ([1627](#1627))

### Bug Fixes

- Fix text in post-plugin-update modal which wasn't showing translated strings properly
- Revert HomeKit code formatting change

---------

Co-authored-by: Ben <43026681+bwp91@users.noreply.github.com>
Co-authored-by: Staubgeborener <eric.schroeder@protonmail.com>
@Staubgeborener
Copy link
Contributor Author

Staubgeborener commented Nov 4, 2023

Where I have edited de.json does this make sense:


Vielen Dank für die Installation der {{ targetVersion }} Version von {{ pluginName }}

{{ targetVersion }} can be latest or beta

German is both extremely flexible but also a very strict language at the same time. Very thankless, especially as we have to adopt some words directly from the english language, translate others and reinvent others.

For example
Vielen Dank für die Installation der beta Version von {{ pluginName }}
Is working. More or less, I think the most of us prefer Beta-Version (so we just "create a new word").

But this one
Vielen Dank für die Installation der latest Version von {{ pluginName }}
definitely don't work. No doubt. latest has to be translated to something like aktuellsten. Edit: the word neuesten which was used before is also okay but aktuellsten sounds more natural imo

@bwp91
Copy link
Contributor

bwp91 commented Nov 4, 2023

“latest” and “beta” are taken directly from the npm tags that plugins are published under. So not easy to translate these.

Perhaps I could add some formatting (would apply to all languages eg

Vielen Dank für die Installation der latest Version von {{ pluginName }}

? thanks for the info by the way.

@Staubgeborener
Copy link
Contributor Author

Maybe by doing this in two steps, so putting the beta/latest version naming into braces after the "thanks for installation" sentence (which should work for all translations), and check the stuff before with an if-statement like

if (plugin.latestVersion?.includes('beta')) { ... }

<p class="text-center grey-text" [translate]="'plugins.manage.message_thanks_for_updating'">
        Thanks for installing  {{ pluginName }}
      </p>

<p class="text-center grey-text" [translate]="'plugins.manage.message_thanks_for_updating_version'"> ((Beta-)|(Aktuellste )Version)
      </p>

This would require two new translations for the i18n files: latest and beta.

But in the end probably a bit much work, I think probably everyone of the german Homebridge users/community knows the meaning of "latest version".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants